Re: [PATCH 5/8] ksmbd: report actual xattr value length in stream enumeration

> diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
> index ffdae74b6..ca3d4985a 100644
> --- a/fs/smb/server/smb2pdu.c
> +++ b/fs/smb/server/smb2pdu.c
> @@ -5865,8 +5865,24 @@ static int get_file_stream_info(struct ksmbd_work *work,
>                 streamlen *= 2;
>                 kfree(stream_buf);
>                 file_info->StreamNameLength = cpu_to_le32(streamlen);
> -               file_info->StreamSize = cpu_to_le64(stream_name_len);
> -               file_info->StreamAllocationSize = cpu_to_le64(stream_name_len);
> +               {
Please avoid introducing an extra scoped block({ ... }) in the middle
of the function.
Thanks.

> +                       /*
> +                        * stream_name_len is the byte length of the xattr's
> +                        * *name*, not its value -- same class of bug
> +                        * ksmbd_stream_eof() (smb2pdu.c) already fixes for
> +                        * EndOfFile/AllocationSize on a stream handle; this
> +                        * enumeration path needs the same real xattr value
> +                        * length, not the name length reused as a size.
> +                        */
> +                       ssize_t slen = ksmbd_vfs_casexattr_len(file_mnt_idmap(fp->filp),
> +                                                              path->dentry,
> +                                                              stream_name,
> +                                                              strlen(stream_name));
> +                       loff_t ssize = slen < 0 ? 0 : (loff_t)slen;
> +
> +                       file_info->StreamSize = cpu_to_le64(ssize);
> +                       file_info->StreamAllocationSize = cpu_to_le64(ssize);
> +               }
>
>                 nbytes += next;
>                 buf_free_len -= next;
> --
> 2.43.0
>