Re: [PATCH v2 4/6] ksmbd: defer CHANGE_NOTIFY completion instead of STATUS_NOT_IMPLEMENTED
ChenXiaoSong <[email protected]>
| Newsgroups | org.kernel.vger.linux-cifs |
|---|---|
| Message-ID | <[email protected]> |
Hi Gaël, Yes, before the cancel response or event notification response is sent, the notify request has not completed yet, so the worker will remain waiting. If you find that this approach causes any issues, we can refactor it and use a better solution. On 7/10/26 16:54, Gaël Blivet wrote: > Makes sense, sorry for the misunderstanding. Could be cleaner, but doesn't wait_for_completion_interruptible() still block a worker thread from ksmbd_wq for as long as the watch stays open? > > Happy to help align the merged patch with your series once it's up. -- ChenXiaoSong <[email protected]> Chinese Homepage: https://chenxiaosong.com English Homepage: https://chenxiaosong.com/en