Re: [PATCH v2 3/3] smb/server: stop new async work when closing connection
ChenXiaoSong <[email protected]>
| Newsgroups | org.kernel.vger.linux-cifs |
|---|---|
| Message-ID | <[email protected]> |
Gaël will update his patch "ksmbd: defer CHANGE_NOTIFY completion instead of STATUS_NOT_IMPLEMENTED". Maybe the next version he won't use synthetic in_work. On 7/16/26 10:25, Namjae Jeon wrote: > setup_async_work() protects only work items registered through that > helper. However, smb2_notify() later creates a synthetic in_work and > adds it directly to conn->async_requests. Therefore, the > connection-close path can finish scanning and cancelling the existing > async requests before in_work is added. in_work is then registered > after the connection enters the releasing state and is not cancelled. > So, we need to protect this direct registration with the same > connection-state check, or use a common helper for all async request > registrations. > Thanks! -- ChenXiaoSong <[email protected]> Chinese Homepage: https://chenxiaosong.com English Homepage: https://chenxiaosong.com/en