Re: [PATCH v2 1/3] smb/server: fix signing when a response uses more than one iov

The condition is always true. The explicit checks were intended to 
document the invalid state, but WARN_ON_ONCE(1) is clearer. I will 
update it. Thanks!

On 7/17/26 16:03, Andy Shevchenko wrote:
> Can you elaborate? The second part is the same check as it's done in
> the for-loop body. The first part checks if we ever go into that loop,
> so the logic here is either we have an invalid input (we skip the loop)
> or always true due to repetition of the check inside, meaning that
> the loop passed without finding the match.
> 
> So, what's the point?

-- 
ChenXiaoSong <[email protected]>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en