Re: [RFC PATCH v2 6/9] ksmbd: support security.capability EAs

Ralph Boehme <[email protected]> Mon, 20 Jul 2026 08:57:42 +0200

Newsgroups	org.kernel.vger.linux-cifs,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On 7/17/26 5:39 AM, Ze Tan wrote:
> +static bool ksmbd_is_posix_ea_name(const char *name, size_t name_len)
> +{
> +	if (ksmbd_is_security_capability_ea_name(name, name_len))
> +		return true;
> +
> +	return false;
> +}
> +
> +static int ksmbd_map_ea_name_to_xattr(bool posix_extensions,
> +				      const char *ea_name, size_t ea_name_len,
> +				      char *attr_name)
> +{
> +	if (posix_extensions &&
> +	    ksmbd_is_posix_ea_name(ea_name, ea_name_len)) {

why the check for allowed namespaces via ksmbd_is_posix_ea_name() at all 
and not just pass through whatever the client sends us, pass it down and 
let the xattr subsystem deal with it?

Still wrapping my head around this so I might be missing something 
obvious. :)

Thanks!
-slow

OpenPGP_signature.asc (application/pgp-signature, 840 B)