Re: [PATCH v2 xfstests 0/3] add generic/795
ChenXiaoSong <[email protected]> Tue, 21 Jul 2026 16:31:59 +0800
| Newsgroups | org.kernel.vger.linux-cifs |
|---|---|
| Message-ID | <[email protected]> |
Hi Zorro, The stat command uses the statx() syscall rather than fstat(), so we have to use a C program to call fstat(). On 7/21/26 16:25, Zorro Lang wrote: > I might not have explained clearly during the review. I wasn't asking you to > rewrite g/002 and lstat64.c. I was suggesting checking whether src/fstat.c in > your previous patch could be replaced by the stat command in xfs_io [1]. Check > `man xfs_io` for the "stat" command to see if it can fulfill your test > requirement. > > Due to I noticed you need information like st_nlink from struct stat, so > `xfs_io -c "stat -r" ...` should meet your requirements. Please > give it a try, if it works, it will make the whole patch much cleaner. > > P.S. For a new test case, please don't use a specific case number (like > generic/795) in the subject or commit log, as it might get assigned a > different number when merged. You can just use something like: > "[PATCH] generic: new test to ..." -- ChenXiaoSong <[email protected]> Chinese Homepage: https://chenxiaosong.com English Homepage: https://chenxiaosong.com/en