Re: [RFC PATCH 00/11] smb/server: change notify support

Do you have any suggestions for this patchset? I plan to send the 
non-RFC version in the next few days.

On 7/23/26 15:20, Namjae Jeon wrote:
> He needs to submit a patch aligned with the current base. We can't
> just wait since we don't know when Gaël will send the patch.

On 7/23/26 11:16, ChenXiaoSong wrote:
> From: ChenXiaoSong <[email protected]>
> 
> Sorry for taking such a long time to complete the ksmbd change notify feature.
> Over the past few months, I have been busy with the birth of my daughter and
> my PhD-related tasks, which left me with limited time to work on it.
> 
> Once Gaël updates his patch ("ksmbd: defer CHANGE_NOTIFY completion instead of STATUS_NOT_IMPLEMENTED"),
> I will rebase my patchset on top of it.
> 
> To test this feature, the following patches need to be applied to cifs-utils and kernel smb client:
>    - cifs-utils: https://chenxiaosong.com/lkml/cifs-utils-parse-notify
>    - kernel smb client: https://chenxiaosong.com/lkml/cifs-improve-notify
> 
> The complete kernel client and server patches are also available at the following link:
> https://chenxiaosong.com/repo/linux/ksmbd-change-notify
> 
> ChenXiaoSong (11):
>    smb/server: add debug type for change notify
>    smb/server: validate notify requests
>    smb/server: support canceling notify requests
>    smb/server: watch directories for changes
>    smb/server: keep notify watches on file handles
>    smb/server: save simple notify events
>    smb/server: save old names for rename notify events
>    smb/server: match rename notify events
>    smb/server: encode notify events
>    smb/server: send notify events to the client
>    smb/server: break directory leases before sending notify events
> 
>   fs/smb/server/Kconfig     |    1 +
>   fs/smb/server/Makefile    |    2 +-
>   fs/smb/server/glob.h      |    3 +-
>   fs/smb/server/notify.c    | 1011 +++++++++++++++++++++++++++++++++++++
>   fs/smb/server/notify.h    |   24 +
>   fs/smb/server/oplock.c    |   40 ++
>   fs/smb/server/oplock.h    |    1 +
>   fs/smb/server/server.c    |    2 +-
>   fs/smb/server/smb2pdu.c   |   12 +-
>   fs/smb/server/vfs_cache.c |    3 +
>   fs/smb/server/vfs_cache.h |    4 +
>   11 files changed, 1095 insertions(+), 8 deletions(-)
>   create mode 100644 fs/smb/server/notify.c
>   create mode 100644 fs/smb/server/notify.h
> 

-- 
ChenXiaoSong <[email protected]>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en