Re: [RFC PATCH 02/11] smb/server: validate notify requests

Namjae Jeon <[email protected]> Sat, 25 Jul 2026 22:31:45 +0900

Newsgroups	org.kernel.vger.linux-cifs
Message-ID	<CAKYAXd_TNmTA=78JcWvHkZT-RagzmJXoFhNdPbQ6dhTVQnzqPg@mail.gmail.com>

> +       if (!S_ISDIR(file_inode(fp->filp)->i_mode)) {
> +               pr_err("Notify file id is not a directory, fid %llu:%llu\n",
> +                      fp->persistent_id, fp->volatile_id);
> +               rsp->hdr.Status = STATUS_NOT_A_DIRECTORY;
CHANGE_NOTIFY request on a non-directory open to fail with
STATUS_INVALID_PARAMETER. Please check [MS-SMB2] section 3.3.5.19.
> +               err = -ENOTDIR;
> +               goto err_put_fp;
> +       }