Re: [PATCH v2] ksmbd: refactor smb2_notify() to a blocking wait, matching smb2_lock()

Hi Gaël,

I tested the macOS client, and it seems that this check is not needed 
either. What issue did you add this check to fix?

On 7/25/26 21:12, ChenXiaoSong wrote:
> When Windows is used as the client, this check must be removed because 
> Windows sends a compound request:
>    CREATE dir; CHANGE_NOTIFY, fid = compound fid (FFFF...FFFF)
> 
> However, I am not yet sure whether skipping this check could cause any 
> issues when macOS is used as the client. I will test it with a macOS 
> client tomorrow.
> 
> 在 2026/7/25 18:26, Gaël Blivet-Bailly 写道:
>> @@ -10967,56 +10908,17 @@ int smb2_notify(struct ksmbd_work *work)
>>       }
>> ...
>> +     * macOS backupd sends CHANGE_NOTIFY with FileId=FFFF...FFFF
>> +     * (share-root sentinel) to watch for changes on the share root
>> +     * without holding an open handle.
>>        */
>>       if (req->VolatileFileId == SMB2_NO_FID &&
>>           req->PersistentFileId == SMB2_NO_FID) {
>> ...
>> +        rsp->hdr.Status = STATUS_INVALID_PARAMETER;
>> +        smb2_set_err_rsp(work);
>>           return 0;
>>       }
> 

-- 
ChenXiaoSong <[email protected]>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en