Re: [PATCH] smb/server: check destination is open when renaming

Ralph Boehme <[email protected]>
Newsgroups org.kernel.vger.linux-cifs
Message-ID <[email protected]>
On 8/4/26 11:40 AM, ChenXiaoSong wrote:
> I am puzzled by Samba's implementation. When mounted with `posix` 
> option, why does `rename_internals_fsp()` still check `found_open = 
> files_forall()` (Link[1])? Based on your description, should it only 
> check non-POSIX opens?

yes.

I was remembering that we had fixed this 2-3 years ago, not sure why 
we're not ignoring the POSIX opens here, looks like a bug.
OpenPGP_signature.asc (application/pgp-signature, 840 B)
-----BEGIN PGP SIGNATURE-----

wsF5BAABCAAjFiEE+uLGCIokJSBRxVnkqh6bcSY5nkYFAmpxt5YFAwAAAAAACgkQqh6bcSY5nkbx
8Q/7B92FR6avnpsR5wbHDBjHdkNN2ySuKiGqd7oELHjQPLZ8iL8vWtkJboNJ4vVTc+/nSJjscRJ+
N1CXXSpQ8IH5OewBLH9CedyKssk1N6F5sSPu+NYqGI3w6uE42PCu02Tdn31j4VGQORiThel/NEP4
LhGeEmDv303ZtdaUDWkTtsCdoCaxBcnT6O3TD9PRcF4sSGQz7yysxnlA6iNXxO8Zyfn+DfdydfuF
WWaETDgvInpS7LPrwxO/eILMX46e98X99GcYvThtqDfcZ3NyUx9nlNDbTsgM+uY3i/72c7lWxKLH
rm99nBM42yEBy/+yD3/hIkXOe3qtK9zRzZHrbkhlXrc5CVMbJlNUVupE1XQlHc468nk3hdU8R7Xq
4SihO9mReJ916ctDZclvFs9ek/sa2Uedjpxg7PPTEiVEWpYp1OTxznY8VWMryzMtW9iYHcLddU/d
k5irGpSeiTv7L9emsUv/MqriIFWEqMgr7wmmcP46YDn/F3pEF2t0AUNLMK15zV4znUYeTYpXw94s
M+G5HSLNb75yVY5Smqckyk73NHHneG8KcbLLqmCeYz802AU/tD9ujkZGK0XEcdqCVzm234OxN/2+
hREFVnetgByPCkdLxe/suvScCxwS7NqA7OJiP2RQWnASwZEgSJlj+BPpi6A5J9moX91k+mxUw8zL
epE=
=jfq+
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.