Re: [PATCH v9 04/26] Add a function to kmap one page of a multipage bio_vec
David Howells <[email protected]>
| Newsgroups | org.kernel.vger.linux-cifs,dev.linux.lists.netfs,dev.linux.lists.v9fs,org.kernel.vger.ceph-devel,org.kernel.vger.linux-block,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.ozlabs.lists.linux-erofs |
|---|---|
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
| Message-ID | <[email protected]> |
Matthew Wilcox <[email protected]> wrote: > On Mon, Aug 10, 2026 at 03:47:21PM +0100, David Howells wrote: > > Add a function to kmap one page of a multipage bio_vec by offset (which is > > added to the offset in the bio_vec internally). The caller is responsible > > for calculating how much of the page is then available. > > I think this should be kmap_local_bvec(). Living in bvec.h makes sense, > but keeping it in the kmap_local_ namespace is better than putting it in > the bvec_ namespace. Christoph disagrees with you:-/ David