Re: [PATCH 3/3] smb/server: check create_proc_shares() failure
Namjae Jeon <[email protected]>
| Newsgroups | org.kernel.vger.linux-cifs |
|---|---|
| Message-ID | <CAKYAXd_tBUao9wk-hkayPpNxVPbJzPRTDRVH4PvmSUu_UxL=Ew@mail.gmail.com> |
On Fri, Aug 14, 2026 at 3:27 PM ChenXiaoSong <[email protected]> wrote: > > These two procfs monitoring entries are indeed optional, if their > creation fails, we should at least print an error message with `pr_err()`. > > However, initialization does not happen frequently, would it be better > to make sure all features are available when initialization completes? I think it would be sufficient to just print error message using pr_warn(). > > On 8/14/26 13:44, Namjae Jeon wrote: > > Do you think we should abort ksmbd > > initialization when create_proc_sessions() or create_proc_shares() > > fail ? > > -- > ChenXiaoSong <[email protected]> > Chinese Homepage: https://chenxiaosong.com > English Homepage: https://chenxiaosong.com/en >