Re: ksmbd: BUG_ON in locks_release_private() - file_lock destroyed while VFS blocked requests are still attached
ChenXiaoSong <[email protected]>
| Newsgroups | org.kernel.vger.linux-cifs |
|---|---|
| Message-ID | <[email protected]> |
Thanks for updating the poc. I have confirmed that the issue can be reproduced without reverting the patch. On 8/14/26 13:51, Blue bird wrote: > The one-line fix on my side is to continue impacket's sequence instead of > inventing one: > > self.tid = self.c.connectTree(SHARE) > - self.mid = 4096 > + self.mid = int(s3._Connection['SequenceWindow']) > > With that, the reproducer works on ksmbd-for-next-next with the sequence window > patch in place -- that is how I got the 1.6 s / 142 request figure above, and > the test of your patch was run the same way, with nothing reverted. > > The other thing that silently zeroes locks_sent is the per-IP connection cap; > the harness churns connections from one address and hits > "Maximum IP connections exceeded (32/32)". I set > > [global] > max ip connections = 0 > > for testing. > > So: a non-zero locks_sent is the thing to check before trusting any negative > result from this reproducer. Sorry for the detour -- I should have flagged it > more loudly when I first hit it. -- ChenXiaoSong <[email protected]> Chinese Homepage: https://chenxiaosong.com English Homepage: https://chenxiaosong.com/en