Re: [PATCH] smb/client: remove redundant NULL check before kfree()

Namjae Jeon <[email protected]>
Newsgroups org.kernel.vger.linux-cifs
Message-ID <CAKYAXd_N3i0jvBn0Nw3-K+U1yS528-ynh0PVETrGuLDnGsZV_g@mail.gmail.com>
On Mon, Aug 17, 2026 at 12:40 AM Huiwen He <[email protected]> wrote:
>
> From: Huiwen He <[email protected]>
>
> kfree() accepts NULL pointers, so checking tmp_cfile before freeing it
> is unnecessary and triggers a Coccinelle warning.
>
> Remove the redundant check. This does not change runtime behavior.
>
> Fixes: 5693347de107 ("smb/client: use writable handle for FS_IOC_SETFLAGS compression")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Huiwen He <[email protected]>
Applied it to #for-next.
Thanks!
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.