RE: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes
"Alim Akhtar" <[email protected]> Tue, 28 Jul 2026 17:53:37 +0530
| Newsgroups | org.kernel.vger.linux-clk,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-samsung-soc |
|---|---|
| Message-ID | <[email protected]> |
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <[email protected]> > Sent: Tuesday, July 28, 2026 5:30 PM > To: raghav.s <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected] > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected] > Subject: Re: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top & > cmu_peric clock DT nodes > > On 28/07/2026 14:11, raghav.s wrote: > > Add required dt node for cmu_top & cmu_peric block > > > > Signed-off-by: raghav.s <[email protected]> > > --- > > arch/arm64/boot/dts/exynos/exynos8855.dtsi | 24 > > ++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > Please organize your patches in reasonable order. DTS is never in the middle, > see submitting patches (both documents) and maintainer-soc profile. > The thought was to add clks block wise and hence we see DTS coming in between but for the other blocks. e.g. patch-2 and 3 adds binding and driver for TOP and PERIC and this patch-4 adds DTS. And patch-5 and 6 adds binding and driver for PERIS and patch-7 adds DTS and so on. Cover-letter should have explained this. Are you suggesting to re-order all the binding first followed by all blocks driver and then add a single DTS for all clock controller? Does current approach helps in review? > Best regards, > Krzysztof