Re: [PATCH] clk: zynq: pll: Fix kernel-doc after determine_rate() conversion
Michal Simek <[email protected]> Mon, 3 Aug 2026 08:07:17 +0200
| Newsgroups | org.kernel.vger.linux-clk,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/2/26 03:32, Babanpreet Singh wrote:
> Commit 1547747b55d5 ("clk: zynq: pll: convert from round_rate() to
> determine_rate()") replaced zynq_pll_round_rate() with
> zynq_pll_determine_rate() but left its kernel-doc block behind, so the
> block still names the old function and documents the removed @rate and
> @prate parameters instead of @req.
>
> Retitle the block and describe @req. The Return: line is updated as
> well: it described a frequency and referenced the removed @rate, while
> the function now returns 0 and reports the rounded rate in @req.
>
> No functional changes.
>
> Assisted-by: Claude:claude-opus-5 [kernel-doc]
> Signed-off-by: Babanpreet Singh <[email protected]>
> ---
> drivers/clk/zynq/pll.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/zynq/pll.c b/drivers/clk/zynq/pll.c
> index 44c6093783641..500586f50d7c1 100644
> --- a/drivers/clk/zynq/pll.c
> +++ b/drivers/clk/zynq/pll.c
> @@ -42,11 +42,11 @@ struct zynq_pll {
> #define PLL_FBDIV_MAX 66
>
> /**
> - * zynq_pll_round_rate() - Round a clock frequency
> + * zynq_pll_determine_rate() - Round a clock frequency
> * @hw: Handle between common and hardware-specific interfaces
> - * @rate: Desired clock frequency
> - * @prate: Clock frequency of parent clock
> - * Return: frequency closest to @rate the hardware can generate.
> + * @req: Clock rate request, updated with the frequency closest to the
> + * requested one that the hardware can generate
> + * Return: 0 on success.
0 always. There is no success/failed here.
Thanks,
Michal