Re: [PATCH v5 4/7] clk: Improve a couple of comments

Frank Li <[email protected]> Fri, 7 Aug 2026 11:23:43 -0500
Newsgroups org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest
Message-ID <anYGjwh_nRiQAsxO@SMW015318>
On Fri, Aug 07, 2026 at 05:24:05PM +0200, Miquel Raynal (Schneider Electric) wrote:
> Avoid mentioning the function names directly in the comments, it makes
> them easily out of sync with the rest of the code. Use a more generic
> wording.
>
> Suggested-by: Stephen Boyd <[email protected]>
> Signed-off-by: Miquel Raynal (Schneider Electric) <[email protected]>
> Reviewed-by: Brian Masney <[email protected]>
> ---

Reviewed-by: Frank Li <[email protected]>

>  drivers/clk/clk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 08874cf9b561..7d63d81ebc09 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -5202,7 +5202,7 @@ static int of_parse_clkspec(const struct device_node *np, int index,
>  		/*
>  		 * For named clocks, first look up the name in the
>  		 * "clock-names" property.  If it cannot be found, then index
> -		 * will be an error code and of_parse_phandle_with_args() will
> +		 * will be an error code and the OF phandle parser will
>  		 * return -EINVAL.
>  		 */
>  		if (name)
> @@ -5275,7 +5275,7 @@ of_clk_get_hw_from_clkspec(struct of_phandle_args *clkspec)
>   *
>   * This function looks up a struct clk from the registered list of clock
>   * providers, an input is a clock specifier data structure as returned
> - * from the of_parse_phandle_with_args() function call.
> + * from the OF phandle parser.
>   */
>  struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec)
>  {
>
> --
> 2.54.0
>