Re: [PATCH RESEND 05/17] phy: spacemit: add Innosilicon DP TX PHY driver

Cody Kang <[email protected]> Sat, 08 Aug 2026 22:14:25 +0800

Newsgroups	org.kernel.vger.linux-clk,dev.linux.lists.spacemit,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-phy,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

Hi Uwe,

On Wed, 29 Jul 2026 14:36:31 +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Sat, Jul 25, 2026 at 12:51:14AM -0400, Cody Kang via B4 Relay wrote:
> > +#include <linux/mod_devicetable.h>
> > [...]
> > +#include <linux/platform_device.h>
>
> <linux/platform_device.h> already makes sure that of_device_id
> is available and <linux/mod_devicetable.h> will go away soon.
>
> So please drop the latter #include.

Thanks for the review. Will do in v2.

Cody