Re: [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support

On 8/11/26 1:19 PM, Dmitry Baryshkov wrote:
> On Tue, May 19, 2026 at 02:17:05PM +0530, Kathiravan Thirumoorthy wrote:
>> Add master/slave IDs for Qualcomm IPQ9650 Network-on-Chip interfaces to
>> support the gcc-ipq9650 driver in providing interconnect services via
>> the icc-clk framework.
> 
> Please consider adding an explanatory text.  Something like:
> 
> On Qualcomm IPQ9650 platform the interconnect busses don't have separate
> RPM / RPMh controls. Instead they require direct votes through the GCC.
> To unify hardware descriptions (and software interfaces) between this
> platform and other Qualcomm platforms, make GCC export corresponding NoC
> clocks as interconnects. Add IDs for these Network-on-Chip interfaces.
> The GCC schema already defines #interconnect-cells since it was added in
> the commit f92b778251ad ("dt-bindings: clock: add Qualcomm IPQ9650
> GCC").
> 
>> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
>> ---
>>   include/dt-bindings/interconnect/qcom,ipq9650.h | 28 +++++++++++++++++++++++++
>>   1 file changed, 28 insertions(+)
> 
> Georgi, any feedback from you? Would you ack merging this patch through
> the Bjorn's trees? Or would you rather pick it up on your own?
> 

I think it would be best if this goes together with the code that is using it.

Acked-by: Georgi Djakov <[email protected]>