Re: [PATCH v2 13/15] dt-bindings: firmware: qcom,scm: Document SCM on Kuno SoC

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing 'qcom,scm-kuno' in the interrupts conditional block of the qcom,scm schema.
--

--- Patch [13]: [PATCH v2 13/15] dt-bindings: firmware: qcom,scm: Document SCM on Kuno SoC ---
commit 3c4b97f23fe59957f3113cdee2e0d2333d4ba10b
Author: Hardeep Sharma <[email protected]>

dt-bindings: firmware: qcom,scm: Document SCM on Kuno SoC

Document the SCM firmware interface found on the Qualcomm Kuno SoC.

> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 037d4ad8f718d..ecee5aef65a7b 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -37,6 +37,7 @@ properties:
>            - qcom,scm-ipq9574
>            - qcom,scm-ipq9650
>            - qcom,scm-kaanapali
> +          - qcom,scm-kuno
>            - qcom,scm-maili
>            - qcom,scm-mdm9607
>            - qcom,scm-milos

[Severity: Low]
Does this compatible string also need to be added to the interrupts conditional
block further down in the file?

If Kuno hardware supports wait-queue interrupts like the parallel Kaanapali
and Maili generations do, omitting it from the allOf interrupts block will
cause a schema validation regression:

allOf:
  # Interrupts
  - if:
      not:
        properties:
          compatible:
            contains:
              enum:
                - qcom,scm-eliza
                - qcom,scm-hawi
                - qcom,scm-kaanapali
                - qcom,scm-maili
                ...
    then:
      properties:
        interrupts: false

Can qcom,scm-kuno be added to this enum list to ensure device trees using the
wait-queue interrupt pass dt_binding_check?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13