Re: [PATCH v6 1/3] dt-bindings: clock: airoha: Document support for AN7583 clock

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] The device tree binding defines the SCU as a reset provider but omits `#reset-cells` from the `required` properties list.
--

--- Patch [1]: [PATCH v6 1/3] dt-bindings: clock: airoha: Document support for AN7583 clock ---
commit d5f1a3bf6c2e7155e5e00666d8f07ae07a173ed5
Author: Christian Marangi <[email protected]>

dt-bindings: clock: airoha: Document support for AN7583 clock

This commit documents support for the Airoha AN7583 clock, building upon the
EN7523 clock schema. It introduces a new requirement for airoha,chip-scu and
adds supplementary bindings for additional clock and reset lines.

> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index eb24a5687639e..edecc635807be 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml

[ ... ]

> @@ -50,12 +51,30 @@ properties:
>      description: ID of the controller reset line
>      const: 1
>  
> +  airoha,chip-scu:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to the Chip SCU providing the registers required
> +      for configuring the PCIe related clocks and resets.
> +
>  required:
>    - compatible
>    - reg
>    - '#clock-cells'

[Severity: Medium]
This is a pre-existing issue, but since the binding defines the SCU as a reset
provider and this patch adds dedicated reset definitions, should #reset-cells
be included in this global required list? 

Without it, device tree nodes using the airoha,an7583-scu compatible string
(or other variants in this binding) that omit #reset-cells will incorrectly
pass schema validation, potentially allowing incomplete device trees to cause
runtime failures in dependent drivers.

>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: airoha,an7583-scu
> +
> +    then:
> +      required:
> +        - airoha,chip-scu

[Severity: Medium]
This is a pre-existing issue regarding reset providers in this file, but if
#reset-cells is not meant to be globally required for all compatibles, should
it be added to this conditional required list specifically for
airoha,an7583-scu alongside airoha,chip-scu?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1