Re: [PATCH v2 16/16] arm64: dts: qcom: talos: Add GCC CX power domain

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `power-domains` property is added to the QCS615 GCC device tree node, but the corresponding YAML dt-binding schema was not updated to allow it.
--

--- Patch [16]: [PATCH v2 16/16] arm64: dts: qcom: talos: Add GCC CX power domain ---
commit 43d59202f59a2d72d12953fe62914471fdc7347f
Author: Abel Vesa <[email protected]>

arm64: dts: qcom: talos: Add GCC CX power domain

This commit adds the RPMh CX power domain reference to the GCC node in
talos.dtsi. This ensures that GCC GDSC consumer votes can propagate
correctly to the required CX power domain.

> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
> index eedfdce3c479e..06ca54acf565f 100644
> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
[ ... ]
> @@ -706,6 +706,8 @@ gcc: clock-controller@100000 {
>  				      "bi_tcxo_ao",
>  				      "sleep_clk";
>  
> +			power-domains = <&rpmhpd RPMHPD_CX>;

[Severity: Low]
Will this new property cause device tree schema validation (make dtbs_check)
to fail?

It looks like the power-domains property is being added here, but the
corresponding dt-binding schema (qcom,qcs615-gcc.yaml) might not have been
updated to allow it. Since the schema typically specifies
unevaluatedProperties: false, adding this property to the dtsi file
without a companion dt-binding update usually introduces a schema violation.

Should there be a companion patch updating the dt-binding YAML?

> +
>  			#clock-cells = <1>;
>  			#reset-cells = <1>;
>  			#power-domain-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=16