Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver
Greg KH <[email protected]> Thu, 19 May 2011 07:22:25 -0700
| Newsgroups | org.kernel.vger.linux-console,org.kernel.vger.linux-kernel,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On Thu, May 19, 2011 at 08:54:31AM -0500, Timur Tabi wrote:
> +/*
> + * The udbg subsystem calls this function to display a single character.
> + * We convert CR to a CR/LF.
> + */
> +static void ehv_bc_udbg_putc(char c)
> +{
> + if (c == '\n')
> + byte_channel_spin_send('\r');
> +
> + byte_channel_spin_send(c);
> +}
Why do this conversion in the driver? Shouldn't that be something that
userspace worries about?
thanks,
greg k-h