Re: [PATCH 2/3] x86/sev: Remove obsolete virtual address check
Eric Biggers <[email protected]> Wed, 22 Jul 2026 15:16:25 +0000
| Newsgroups | org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jul 22, 2026 at 12:01:43PM +0200, Ard Biesheuvel wrote: > > > On Wed, 22 Jul 2026, at 04:53, Eric Biggers wrote: > > Virtual addresses used with the AES-GCM library don't have to be in the > > linear mapping. Remove the virt_addr_valid() checks from > > snp_send_guest_request(), which were a workaround left over from when > > this code used crypto_aead, which required scatterlists. > > > > Signed-off-by: Eric Biggers <[email protected]> > > --- > > arch/x86/coco/sev/core.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > Link: https://lore.kernel.org/all/[email protected]/ > Thanks, I completely missed that. Looks like the usual issue where people were attached to workarounds even after the underlying problem was fixed. In the end, Alexey gave Reviewed-by and Tested-by on the exact same diff, just it never got applied. Alexey, would you mind if I add those tags to this patch too? Thanks! - Eric