Re: [PATCH] crypto: qce - fix error path in devm_qce_register_algs

On Fri, 24 Jul 2026 10:15:38 +0200, Thorsten Blum
<[email protected]> said:
> If ops->register_algs() fails, the error path repeatedly calls the same
> ops->unregister_algs() from the failed registration. Use the loop index
> to unregister the previously registered algorithms instead.
>
> Fixes: e80cf84b6087 ("crypto: qce - unregister previously registered algos in error path")
> Cc: [email protected]
> Signed-off-by: Thorsten Blum <[email protected]>
> ---
>  drivers/crypto/qce/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
> index ac74f69914d6..ea5b9689ce68 100644
> --- a/drivers/crypto/qce/core.c
> +++ b/drivers/crypto/qce/core.c
> @@ -58,7 +58,7 @@ static int devm_qce_register_algs(struct qce_device *qce)
>  		ret = ops->register_algs(qce);
>  		if (ret) {
>  			for (j = i - 1; j >= 0; j--)
> -				ops->unregister_algs(qce);
> +				qce_ops[j]->unregister_algs(qce);
>  			return ret;
>  		}
>  	}
>

Reviewed-by: Bartosz Golaszewski <[email protected]>