Re: [PATCH] crypto: keembay - Initialize completion before requesting IRQ
Herbert Xu <[email protected]> Mon, 27 Jul 2026 10:32:22 +1000
| Newsgroups | org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 14, 2026 at 11:30:15AM +0800, Linmao Li wrote:
> kmb_ocs_aes_probe() requests the device IRQ before initializing
> irq_completion. Once the handler is registered it can run immediately,
> and ocs_aes_irq_handler() unconditionally calls complete(). An
> interrupt in this window would therefore use an uninitialized
> completion.
>
> Initialize the completion before requesting the IRQ, as the sibling
> OCS HCU and ECC drivers already do.
>
> Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4")
> Signed-off-by: Linmao Li <[email protected]>
> ---
> drivers/crypto/intel/keembay/keembay-ocs-aes-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt