Re: [PATCH v6 1/8] crypto: qce - Fix HMAC self-test failures for empty messages

Bartosz Golaszewski <[email protected]> Thu, 30 Jul 2026 01:53:01 -0700

Newsgroups	org.kernel.vger.linux-crypto,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID	<CAMRc=MfeuA7YX8Z=fL4TMQ4kmm-ti6p+M9YOKoS+5ODUCyHZdQ@mail.gmail.com>

On Mon, 27 Jul 2026 01:08:31 +0200, Herbert Xu
<[email protected]> said:
> On Thu, Jul 23, 2026 at 12:25:14PM -0700, Eric Biggers wrote:
>>
>> I'm trying to understand how this is intended to work.  This uses
>> crypto_tfm::fb.  But this driver doesn't set CRYPTO_ALG_NEED_FALLBACK,
>> so crypto_tfm::fb is actually just a pointer to the same crypto_tfm.
>> (See crypto_create_tfm_node() and crypto_ahash_init_tfm().)  Doesn't
>> this just result in an infinite recursive loop and a crash?
>
> Every async driver gets a fallback by default, unless you set
> the bit CRYPTO_ALG_NO_FALLBACK or you declare that you support
> CRYPTO_ALG_REQ_VIRT (which no driver does).
>

Herbert,

Is there anything else I need to do for this series to get picked up?

Thanks,
Bartosz