Re: [PATCH v11 3/6] x86/sev: Initialize RMPOPT configuration MSRs
"Kalra, Ashish" <[email protected]> Thu, 30 Jul 2026 15:00:55 -0500
| Newsgroups | org.kernel.vger.linux-crypto,dev.linux.lists.linux-coco,org.kernel.vger.kvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello Boris, On 7/29/2026 9:07 PM, Borislav Petkov wrote: > >> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c >> index ca473ca198b8..c002a7ca26a8 100644 >> --- a/drivers/crypto/ccp/sev-dev.c >> +++ b/drivers/crypto/ccp/sev-dev.c >> @@ -1477,6 +1477,9 @@ static int __sev_snp_init_locked(int *error, unsigned int max_snp_asid) >> } >> >> snp_hv_fixed_pages_state_update(sev, HV_FIXED); >> + >> + snp_setup_rmpopt(); > > Why is this thing here and not at the end? > > SEV-TIO is supposed to always run last or it doesn't matter? > No hard dependency — it only needs SNP initialized (post SNP_INIT_EX/DF_FLUSH), and the initial pass is async anyway, so it's independent of the SEV-TIO block and the panic notifier. So i can move it to the end (after the TIO block so it runs last without touching TIO ordering), but is there a specific reason you want me to move it to the end, as it can just stay here after SNP_INIT. Thanks, Ashish