Re: [PATCH] crypto: qce - Replace with stub driver
Eric Biggers <[email protected]> Fri, 31 Jul 2026 03:02:14 -0700
| Newsgroups | org.kernel.vger.linux-crypto,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260731100214.GA1927@quark> |
On Fri, Jul 31, 2026 at 11:06:28AM +0200, Krzysztof Kozlowski wrote: > On 31/07/2026 07:08, Eric Biggers wrote: > > None of the algorithms the QCE driver registers with the crypto API are > > even close to being useful. They're massively outperformed by the > > The amount of patches you send towards removal of QCE is really > stunning. Or rather worrying. This is like third approach or so. Note that the crypto maintainer has already accepted a patch from another developer to mark this driver as BROKEN. > This is beyond comprehension and very unpleasant, because you actively > work against the community with this approach. "The community" is more than the hardware vendor. I think the results of independent testing of this driver are incredibly clear. The pending fixes do not fix the performance either, but actually make it worse. I have been asking for the inclusion of this driver to be justified for many years. As far as I've ever been able to tell it's just a "checkbox feature", which isn't something that really belongs upstream. I care about the technical merit of the kernel's cryptographic algorithm implementations. - Eric