[PATCH v2 0/2] Fix skcipher_walk return code handling in aes_s390
Harald Freudenberger <[email protected]>
| Newsgroups | org.kernel.vger.linux-crypto,org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
The return codes from skcipher_walk_virt() were not properly checked
before entering the processing loops in ecb_aes_crypt() and ctr_aes_crypt().
If skcipher_walk_virt() fails, the walk structure may be in an undefined
state, and attempting to process data could lead to incorrect behavior
or accessing uninitialized memory.
Add proper return code checking to ensure correct handling of the walk
initialization and walk advance and eventually return to the caller
with that return code.
Patch #2 deals with a not scrubbed temp buffer.
Changelog:
v1: initial version
v2: Fix missing scrub on a temp buffer used to process left over bytes
in CTR mode.
Harald Freudenberger (2):
s390/crypto: Fix skcipher_walk return code handling in aes_s390
s390/crypto: Explicit scrub temp buffer in AES ctr mode algorithm
arch/s390/crypto/aes_s390.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
--
2.43.0