Re: [PATCH v2 2/2] s390/crypto: Explicit scrub temp buffer in PAES ctr mode algorithm
Holger Dengler <[email protected]>
| Newsgroups | org.kernel.vger.linux-crypto,org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
On 8/5/26 17:54, Harald Freudenberger wrote:
> In function ctr_paes_do_crypt() there is a buffer used to process
> remaining bytes < AES_BLOCK_SIZE. This buffer was not scrubbed and
> thus could lead to expose of unwanted data.
>
> On exit of the function unconditionally scrub this buffer to avoid
> exposure of maybe sensitive data.
>
> Fixes: 6cd87cb5ef6c ("s390/crypto: Rework protected key AES for true asynch support")
> Signed-off-by: Harald Freudenberger <[email protected]>
> Cc: [email protected] # 6.16+
I would've preferred the scrub buf only if it is used. But your solution
is also ok for me.
Reviewed-by: Holger Dengler <[email protected]>
--
Mit freundlichen Grüßen / Kind regards
Holger Dengler