Re: [PATCH v3 2/4] crypto: rockchip: Add RK356x/RK3588 cryptographic offloader driver

On Tue, Aug 18, 2026 at 09:36:44AM +0200, Krzysztof Kozlowski wrote:
> On Sun, Aug 16, 2026 at 08:39:45PM +0100, Dawid Olesinski wrote:
> > Add a driver for the second-generation Rockchip cryptographic hardware
> > accelerator found on RK3568 and RK3588 SoCs (compatible strings
> > "rockchip,rk3568-crypto" and "rockchip,rk3588-crypto").
> > 
> > The hardware provides:
> >   - AES block cipher engine: ECB, CBC, and XTS modes, 128/192/256-bit
> >     keys. XTS hardware is limited to single-SG requests.
> >   - Hash engine: SHA-1, SHA-256, SHA-384, SHA-512, MD5, SM3.
> >     The hardware padding engine (HW_PAD) requires the total message
> >     length upfront and cannot maintain state across LLI descriptor
> >     boundaries, so multi-SG and unaligned requests are routed to a
> >     software fallback.
> >   - DMA engine: linked-list descriptor (LLI) based, with a 20-entry
> >     coherent descriptor table.
> 
> Hardware encryption drivers are being removed or at least tried to be
> removed multipled times, so would be nice to see here WHY this one
> should be added.

Well, it is the usual drivers/crypto/ pattern.  It's being pushed as an
"accelerator" despite the SoC already having ARMv8 CE which is almost
certainly much faster (ARMv8 CE support is mentioned in the datasheet),
MD5 (!) is being pushed for some reason, it's not properly tested, and
no use case is described.  These crypto driver submissions are basically
spam at this point.  Only thing that really saves them is that not many
people have the hardware, so there tend not to be independent voices in
the room besides the people pushing the driver as a checkbox feature.

- Eric