Re: [PATCH v2 1/1] acpi/hmat: preserve hmat_adist_nb notifier block

Jonathan Cameron <[email protected]>
Newsgroups org.kernel.vger.linux-cxl,org.kernel.vger.linux-acpi
Organization Qualcomm
Message-ID <[email protected]>
On Thu, 16 Jul 2026 13:27:56 -0700
Dave Jiang <[email protected]> wrote:

> On 7/16/26 11:11 AM, [email protected] wrote:
> > From: Alejandro Lucero <[email protected]>
> > 
> > Remove __meminitdata from hmat_adist_nb declaration preserving it even
> > when CONFIG_MEMORY_HOTPLUG is not set. Otherwise further notifier
> > registrations using register_mt_adistance_algorithm() will find a
> > notifier chain likely corrupted.
> > 
> > This is the case when cxl_region_probe() calls
> > register_mt_adistance_algorithm() what can happen when CXL regions
> > are dynamically created at any time from Type3 device(s) or when a Type2
> > device is initialized at its driver probe.
> > 
> > Fixes: 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT")
> > 

This will trip some of the checker scripts that run on various trees.
No blank lines in a commit tag block. I guess who ever picks this up
can tidy that up though rather than needing a v2.

> > Signed-off-by: Alejandro Lucero <[email protected]>  
> 
> Reviewed-by: Dave Jiang <[email protected]>
Seems sensible to me.

Reviewed-by: Jonathan Cameron <[email protected]>

> 
> 
> > ---
> >  drivers/acpi/numa/hmat.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
> > index 9792dc394756..3006789ae31f 100644
> > --- a/drivers/acpi/numa/hmat.c
> > +++ b/drivers/acpi/numa/hmat.c
> > @@ -995,7 +995,7 @@ static int hmat_calculate_adistance(struct notifier_block *self,
> >  	return NOTIFY_STOP;
> >  }
> >  
> > -static struct notifier_block hmat_adist_nb __meminitdata = {
> > +static struct notifier_block hmat_adist_nb = {
> >  	.notifier_call = hmat_calculate_adistance,
> >  	.priority = 100,
> >  };  
> 
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.