Re: [PATCH v18 12/13] PCI/CXL: Mask/Unmask CXL protocol errors
| Newsgroups | org.kernel.vger.linux-cxl,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> CXL protocol errors are not enabled for all CXL devices after boot. > They must be enabled in order to process CXL protocol errors. Provide > matching teardown helpers so the masks are restored when a CXL Port > or dport goes away. > > Add pci_aer_mask_internal_errors() as the symmetric counterpart to > pci_aer_unmask_internal_errors() and export both for the cxl_core > module. > > Introduce cxl_unmask_proto_interrupts() and cxl_mask_proto_interrupts() > in cxl_core to wrap the PCI helpers with the dev_is_pci() and > pcie_aer_is_native() gating CXL needs. Both helpers tolerate a NULL > or non-PCI @dev so callers do not have to special-case it. > > Wire cxl_unmask_proto_interrupts() into the success path of > [ ... ] > which is sufficient to exclude cxl_test mock devices. > > Co-developed-by: Dan Williams <[email protected]> > Signed-off-by: Dan Williams <[email protected]> > Signed-off-by: Terry Bowman <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12