Re: [PATCH v4 0/4] Harden HDM decoder enumeration

On Mon, Jul 20, 2026 at 06:59:36PM +0800, Alison Schofield wrote:
> Changes in v4:
> A new patch was inserted as Patch2, so now set is 4 patches.
>    Sashiko is likely to complain in Patch 1 for something fixed in
>    Patches 2 and 3, but reordering does not makes sense.
> P2: Only interpret interleave settings on committed decoders (Ming)
>     This is the newly inserted patch
> P4: Register reset w devm_add_action (Ming)
> P4: Fix up a kernel-doc comment issue (lkp)
> 
> Changes in v3:
> P1: Move zero-target reject to init_hdm_decoder() (RichardC)
> P3: Reset commit_end via a devres action after decoder teardown (RichardC)
> 
> Changes in v2:
> P1: Handle uncommitted decoders (Sashiko)
> P1: Reject switch decoders with zero targets (Sashiko)
> P1: Add in code comment clarifying target_count (Sashiko)
> P1: Update commit log
> P3: Reset commit_end on the failure path only (Sashiko)
> P3: Update commit log
> No changes in P2
> 
> 
> This set started as Sashiko reported cleanups, and at v4, Patch 2/4
> was added based on Li Ming's review and catch.
> 
> Only the first includes a link to the original Sashiko complaint, since
> the others did not originally appear on Lore for me to add public links. 
> 
> Srirangan: I believe patches 1 and 3 of these also address pre-existing
> issues Sashiko posted in reply to your reset series, Patch 02/11.
> 
> 
> Alison Schofield (4):
>   cxl/hdm: Reject switch decoder interleave ways that overflow targets
>   cxl/hdm: Only interpret interleave settings on committed decoders
>   cxl/hdm: Make switch decoder target parsing endian-safe
>   cxl/hdm: Restore commit_end when decoder enumeration fails
> 
>  drivers/cxl/core/hdm.c | 98 +++++++++++++++++++++++++++++++-----------
>  drivers/cxl/cxl.h      |  2 +
>  2 files changed, 76 insertions(+), 24 deletions(-)
> 
> 
> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
> -- 
> 2.37.3
> 
>

Reviewed-by: Richard Cheng <[email protected]>