Re: [PATCH v2 3/6] hw/cxl: convert cxl-type3 to three-phase reset

Philippe Mathieu-Daudé <[email protected]> Thu, 23 Jul 2026 08:03:16 +0200
Newsgroups org.kernel.vger.linux-cxl,org.nongnu.qemu-devel
Message-ID <[email protected]>
On 23/7/26 03:16, Junjie Cao wrote:
> Replace the deprecated device_class_set_legacy_reset() registration
> with the three-phase resettable interface, following the pattern
> already established by the CXL root port (cxl_rp_reset_hold).
> 
> Only the hold phase is needed; enter and exit are left NULL.  The
> parent hold phase is chained for correctness: TYPE_PCI_DEVICE installs
> no hold phase today, so parent_phases.hold is currently NULL and the
> chained call is a no-op, but capturing and invoking it is the correct
> forward-compatible pattern and mirrors cxl_rp_reset_hold().
> 
> No functional change — the reset body is identical; only the
> registration path and function signature change.
> 
> Signed-off-by: Junjie Cao <[email protected]>
> ---
>   hw/mem/cxl_type3.c          | 16 ++++++++++++----
>   include/hw/cxl/cxl_device.h |  2 ++
>   2 files changed, 14 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>