Re: [PATCH v2 11/12] migration/multifd: fix Error leak in multifd_recv_terminate_threads()

Marc-André Lureau <[email protected]> writes:

> If err != NULL, free it.
>
> Fixes: 11dd7be57524 ("migration/multifd: Remove p->quit from recv side")
> Signed-off-by: Marc-André Lureau <[email protected]>
> ---
>  migration/multifd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/migration/multifd.c b/migration/multifd.c
> index dbad525d2a28..503014f76ba5 100644
> --- a/migration/multifd.c
> +++ b/migration/multifd.c
> @@ -1056,6 +1056,7 @@ static void multifd_recv_terminate_threads(Error *err)
>      trace_multifd_recv_terminate_threads(err != NULL);
>  
>      if (qatomic_xchg(&multifd_recv_state->exiting, 1)) {
> +        error_free(err);
>          return;
>      }

Reviewed-by: Fabiano Rosas <[email protected]>