Re: [PATCH v6 0/9] cxl: Support Back-Invalidate
Dave Jiang <[email protected]> Mon, 27 Jul 2026 16:02:12 -0700
| Newsgroups | org.kernel.vger.linux-cxl,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/27/26 2:26 PM, Davidlohr Bueso wrote: > On Mon, 27 Jul 2026, Jonathan Cameron wrote: > >> On Mon, 27 Jul 2026 12:35:52 -0700 >> Davidlohr Bueso <[email protected]> wrote: >> >>> Hello, >> >> Hi Davidlohr, >> >> You missed linux-cxl > > bleh yeah that was a braino, I meant cxl not lkml - probably not worth another respin, > but Cc'ing here. You may want to resend if you want sashiko coverage. > >> >> J >>> >>> Changes from v5 (https://lore.kernel.org/all/[email protected]): >>> - Patch 1 documented the BI register block with the spec references >>> at the definitions. (Dave) >>> - Patch 2 split the enable/rollback into a helper so the unwind path >>> no longer mixes goto and scope-based cleanup (Sashiko). >>> - Patch 2 reworded the changelog around root port enablement. >>> - Patch 3 introduced cxled_default_type() so decoders present the >>> device's default target type when not attached to a region (Sashiko). >>> - Patch 4 defaults to host-only when firmware sets both CFMWS >>> coherency restrictions (Richard). >>> - Patch 4 restores the default target type on detach, fixing a stale >>> DEVMEM type leaking into a later HDM-H attach (Sashiko). >>> - Patch 4 'bi' sysfs now reports against the attached region's root >>> decoder rather than device state alone (Sashiko). >>> - Picked up review tags (thanks!). >>> - New patch 6: trivially log the coherency model at region creation dbg. >>> - New patches 7-9: move BI setup to endpoint port probe, split the >>> capability probe from BI-ID allocation, and allow for auto-committed >>> BI decoders instead of failing enumeration. >>> >>> This series is the initial plumbing to enable HDM-DB in Linux. The >>> model allows Type 2 and Type 3 devices to expose their local memory >>> to the host CPU in a coherent manner. In alignment with what was >>> discussed at 2024 LPC type2 support session, this series takes the >>> Type 3 memory expander approach, which is more direct. Further, >>> afaik there is no Type 2 + BI hardware out there. >>> >>> A flagship use case of Type 3 + BI is coherent shared memory, and >>> there is currently a big gap in this regard (ie: GFAM). Another >>> is P2P via PCIe UIO, which is also lacking today. Media Operation >>> (4402h) for ranged sanitize/zero also trigger snoops and there are >>> some patches out there[0]. As such this series focuses on BI enablement >>> in terms of discovery and configuration. >>> >>> The idea is for Type 3 memdevs and Type 2 devices to make use of >>> cxlds->bi when committing HDM decoders, such that different device >>> coherence models can be differentiated as: >>> >>> type2 hdm-d: cxlds->type == CXL_DEVTYPE_DEVMEM && cxlds->bi == false >>> type2 hdm-db: cxlds->type == CXL_DEVTYPE_DEVMEM && cxlds->bi == true >>> type3 hdm-h: cxlds->type == CXL_DEVTYPE_CLASSMEM && cxlds->bi == false >>> type3 hdm-db: cxlds->type == CXL_DEVTYPE_CLASSMEM && cxlds->bi == true >>> >>> Unlike previous versions, an auto-committed BI decoder found during >>> enumeration is no longer rejected: patches 7-9 adopt the inherited >>> configuration when the device and path are BI capable, refusing only >>> broken combinations. See the auto-discovery tests section below. >>> >>> o Patch 1 probes BI capabilities during register discovery, and maps BI >>> Decoder registers. >>> >>> o Patch 2 implements the BI-ID allocation (and deallocation). >>> >>> o Patch 3 adds coherency support for endpoint decoders based on what the >>> root decoder restricts. >>> >>> o Patch 4 adds support for HDM-DB region creation. >>> >>> o Patch 5 trivially renames some coherency flags. >>> >>> o Patch 6 logs the coherency model (HDM-H, HDM-D, HDM-DB) when a >>> region is created. >>> >>> o Patch 7 moves BI setup to endpoint port probe, tying the BI-ID >>> lifetime to the endpoint port. >>> >>> o Patch 8 splits the BI capability walk from BI-ID allocation so the >>> answer is available when committed decoders are first parsed. >>> >>> o Patch 9 allows committed BI decoders. Overall this series >>> could be picked up with or without this patch. >>> >>> Please note that patch 7+8 could be consolidated into patch 2, >>> instead of starting out with cxl_mem but I chose to add them >>> incrementally because 1) want to see what sashiko says, >>> 2) it isolates the requirements for the auto-committed support >>> (patch 9); 3) details why endpoint lifecycle is safe and >>> 4) reuses already valuable review times of the current state >>> of the series. But I certainly see the reasons to avoid the >>> additional patches. >>> >>> Testing >>> ------- >>> >>> Testing has been done on top of upstream qemu with the CFMW options series: >>> >>> https://lore.kernel.org/all/[email protected]/ >>> >>> A new qemu-based test suite has been added for full automation and pounding, >>> covering many topologies and corner cases: >>> >>> https://github.com/davidlohr/cxl-bi-tests >>> >>> This passes regression testing (nothing breaks) ndctl suite via cxl_test. >>> >>> 1. HDM Decoder with BI through ad-hoc region creation. >>> ------------------------------------------------------ >>> # cxl list -D >>> [ >>> { >>> "decoder":"decoder0.0", >>> "resource":6710886400, >>> "size":4294967296, >>> "interleave_ways":1, >>> "accelmem_capable":true, >>> "nr_targets":1 >>> } >>> ] >>> >>> # ROOT=/sys/bus/cxl/devices/decoder0.0 >>> # EP=/sys/bus/cxl/devices/decoder2.0 >>> # echo region0 > $ROOT/create_ram_region >>> [ 7.662871] cxl_core:devm_cxl_add_region:2829: cxl_acpi ACPI0017:00: decoder0.0: created HDM-DB region0 >>> # REG=/sys/bus/cxl/devices/region0 >>> # echo ram > $EP/mode >>> # echo 0x40000000 > $EP/dpa_size >>> # echo 1 > $REG/interleave_ways >>> # echo 4096 > $REG/interleave_granularity >>> # echo 0x40000000 > $REG/size >>> # cat $EP/bi >>> 0 >>> # echo decoder2.0 > $REG/target0 >>> [ 8.153566] cxl_core:cxl_port_attach_region:1295: cxl region0: mem0:endpoint2 decoder2.0 add: mem0:decoder2.0 @ 0 next: none nr_eps: 1 nr_targets: 1 >>> [ 8.157683] cxl_core:cxl_port_attach_region:1295: cxl region0: pci0000:0c:port1 decoder1.0 add: mem0:decoder2.0 @ 0 next: mem0 nr_eps: 1 nr_targets: 1 >>> [ 8.159570] cxl_core:cxl_port_setup_targets:1630: cxl region0: pci0000:0c:port1 iw: 1 ig: 4096 >>> [ 8.160487] cxl_core:cxl_port_setup_targets:1638: cxl region0: pci0000:0c:port1 target[0] = 0000:0c:00.0 for mem0:decoder2.0 @ 0 >>> [ 8.161759] cxl_core:cxl_calc_interleave_pos:2046: cxl_mem mem0: decoder:decoder2.0 parent:0000:0d:00.0 port:endpoint2 range:0x190000000-0x1cfffffff pos:0 >>> [ 8.163681] cxl_core:cxl_region_attach:2270: cxl decoder2.0: Test cxl_calc_interleave_pos(): success test_pos:0 target->pos:0 >>> # cat $EP/bi >>> 1 >>> # echo 1 > $REG/commit >>> # cxl list -D >>> [ >>> { >>> "root decoders":[ >>> { >>> "decoder":"decoder0.0", >>> "resource":6710886400, >>> "size":4294967296, >>> "interleave_ways":1, >>> "accelmem_capable":true, >>> "nr_targets":1 >>> } >>> ] >>> }, >>> { >>> "port decoders":[ >>> { >>> "decoder":"decoder1.0", >>> "resource":6710886400, >>> "size":1073741824, >>> "interleave_ways":1, >>> "region":"region0", >>> "nr_targets":1 >>> } >>> ] >>> }, >>> { >>> "endpoint decoders":[ >>> { >>> "decoder":"decoder2.0", >>> "resource":6710886400, >>> "size":1073741824, >>> "interleave_ways":1, >>> "region":"region0", >>> "dpa_resource":0, >>> "dpa_size":1073741824, >>> "mode":"ram" >>> } >>> ] >>> } >>> ] >>> >>> 2. Type3 device does not support BI, but CFMW has BI restriction >>> ---------------------------------------------------------------- >>> # echo decoder2.0 > $REG/target0 >>> [ 7.311927] cxl region0: mem0:decoder2.0 BI not enabled on device >>> [ 7.313907] cxl_port endpoint2: failed to attach decoder2.0 to region0: -6 >>> >>> 3. Type3 device supports BI but CFMW does not, create HDM-H region >>> ------------------------------------------------------------------ >>> # cxl list -D >>> [ >>> { >>> "decoder":"decoder0.0", >>> "resource":6710886400, >>> "size":4294967296, >>> "interleave_ways":1, >>> "max_available_extent":4294967296, >>> "pmem_capable":true, >>> "volatile_capable":true, >>> "accelmem_capable":true, >>> "nr_targets":1 >>> } >>> ] >>> # echo region0 > $ROOT/create_ram_region >>> [ 7.679496] cxl_core:devm_cxl_add_region:2829: cxl_acpi ACPI0017:00: decoder0.0: created HDM-H region0 >>> # cat $EP/bi >>> 0 >>> # echo decoder2.0 > $REG/target0 >>> [ 8.165400] cxl_core:cxl_port_attach_region:1295: cxl region0: mem0:endpoint2 decoder2.0 add: mem0:decoder2.0 @ 0 next: none nr_eps: 1 nr_targets: 1 >>> [ 8.167128] cxl_core:cxl_port_attach_region:1295: cxl region0: pci0000:0c:port1 decoder1.0 add: mem0:decoder2.0 @ 0 next: mem0 nr_eps: 1 nr_targets: 1 >>> [ 8.168834] cxl_core:cxl_port_setup_targets:1630: cxl region0: pci0000:0c:port1 iw: 1 ig: 4096 >>> [ 8.169893] cxl_core:cxl_port_setup_targets:1638: cxl region0: pci0000:0c:port1 target[0] = 0000:0c:00.0 for mem0:decoder2.0 @ 0 >>> [ 8.171302] cxl_core:cxl_calc_interleave_pos:2046: cxl_mem mem0: decoder:decoder2.0 parent:0000:0d:00.0 port:endpoint2 range:0x190000000-0x1cfffffff pos:0 >>> [ 8.173036] cxl_core:cxl_region_attach:2270: cxl decoder2.0: Test cxl_calc_interleave_pos(): success test_pos:0 target->pos:0 >>> # echo 1 > $REG/commit >>> # cat $EP/bi >>> 0 >>> >>> 4. Unbind + Bind >>> ---------------- >>> # echo mem0 > /sys/bus/cxl/drivers/cxl_mem/unbind >>> [ 7.645330] cxl_core:__cxl_bi_ctrl_endpoint:1218: cxl_pci 0000:0d:00.0: BI requests disabled >>> [ 7.648838] cxl_core:cxl_port_commit_reap:900: cxl_port endpoint2: reap: decoder2.0 commit_end: -1 >>> [ 7.651284] cxl_core:cxl_detach_ep:1556: cxl_mem mem0: disconnect mem0 from port1 >>> >>> # echo mem0 > /sys/bus/cxl/drivers/cxl_mem/bind >>> [ 8.909437] cxl_core:devm_cxl_enumerate_ports:1871: cxl_mem mem0: scan: iter: mem0 dport_dev: 0000:0c:00.0 parent: pci0000:0c >>> [ 8.911170] cxl_core:devm_cxl_enumerate_ports:1877: cxl_mem mem0: found already registered port port1:pci0000:0c >>> [ 8.945969] cxl_core:init_hdm_decoder:1128: cxl_port endpoint2: decoder2.0: range: 0x0-0xffffffffffffffff iw: 1 ig: 4096 >>> [ 8.949705] cxl_core:add_hdm_decoder:39: cxl_mem mem0: decoder2.0 added to endpoint2 >>> [ 8.960378] cxl_core:__cxl_bi_ctrl_endpoint:1218: cxl_pci 0000:0d:00.0: BI requests enabled >>> [ 8.961196] cxl_core:cxl_bus_probe:2299: cxl_port endpoint2: probe: 0 >>> [ 8.962592] cxl_core:cxl_bus_probe:2299: cxl_mem mem0: probe: 0 >>> >>> The same applies to the endpoint port, with the memdev rebind recovering the endpoint: >>> >>> # echo endpoint2 > /sys/bus/cxl/drivers/cxl_port/unbind >>> [ 10.483509] cxl_core:__cxl_bi_ctrl_endpoint:1218: cxl_pci 0000:0d:00.0: BI requests disabled >>> [ 10.487570] cxl_core:cxl_port_commit_reap:900: cxl_port endpoint2: reap: decoder2.0 commit_end: -1 >>> [ 10.491501] cxl_core:cxl_detach_ep:1556: cxl_mem mem0: disconnect mem0 from port1 >>> >>> # echo mem0 > /sys/bus/cxl/drivers/cxl_mem/bind >>> [ 11.754957] cxl_core:devm_cxl_enumerate_ports:1871: cxl_mem mem0: scan: iter: mem0 dport_dev: 0000:0c:00.0 parent: pci0000:0c >>> [ 11.756343] cxl_core:devm_cxl_enumerate_ports:1877: cxl_mem mem0: found already registered port port1:pci0000:0c >>> [ 11.789821] cxl_core:init_hdm_decoder:1128: cxl_port endpoint2: decoder2.0: range: 0x0-0xffffffffffffffff iw: 1 ig: 4096 >>> [ 11.794674] cxl_core:add_hdm_decoder:39: cxl_mem mem0: decoder2.0 added to endpoint2 >>> [ 11.805772] cxl_core:__cxl_bi_ctrl_endpoint:1218: cxl_pci 0000:0d:00.0: BI requests enabled >>> [ 11.806810] cxl_core:cxl_bus_probe:2299: cxl_port endpoint2: probe: 0 >>> [ 11.808661] cxl_core:cxl_bus_probe:2299: cxl_mem mem0: probe: 0 >>> >>> From a cold boot, without a region ever created, the endpoint port >>> unbind only disables BI - there is no committed decoder to reap: >>> >>> # echo endpoint2 > /sys/bus/cxl/drivers/cxl_port/unbind >>> [ 22.046813] cxl_core:__cxl_bi_ctrl_endpoint:1218: cxl_pci 0000:0d:00.0: BI requests disabled >>> [ 22.049676] cxl_core:cxl_detach_ep:1556: cxl_mem mem0: disconnect mem0 from port1 >>> >>> # echo mem0 > /sys/bus/cxl/drivers/cxl_mem/bind >>> [ 24.270628] cxl_core:devm_cxl_enumerate_ports:1871: cxl_mem mem0: scan: iter: mem0 dport_dev: 0000:0c:00.0 parent: pci0000:0c >>> [ 24.273682] cxl_core:devm_cxl_enumerate_ports:1877: cxl_mem mem0: found already registered port port1:pci0000:0c >>> [ 24.312426] cxl_core:init_hdm_decoder:1128: cxl_port endpoint2: decoder2.0: range: 0x0-0xffffffffffffffff iw: 1 ig: 256 >>> [ 24.315677] cxl_core:add_hdm_decoder:39: cxl_mem mem0: decoder2.0 added to endpoint2 >>> [ 24.332406] cxl_core:__cxl_bi_ctrl_endpoint:1218: cxl_pci 0000:0d:00.0: BI requests enabled >>> [ 24.334427] cxl_core:cxl_bus_probe:2299: cxl_port endpoint2: probe: 0 >>> [ 24.337952] cxl_core:cxl_bus_probe:2299: cxl_mem mem0: probe: 0 >>> >>> 5. Discovery behind a Switch >>> ---------------------------- >>> [ 0.782301] cxl_core:cxl_probe_component_regs:102: cxl_pci 0000:0f:00.0: found BI Decoder capability (0xab4) >>> [ 0.851085] cxl_core:cxl_probe_component_regs:102: pcieport 0000:0c:00.0: found BI Decoder capability (0xab4) >>> [ 0.866840] cxl_core:cxl_probe_component_regs:96: cxl_port port2: found BI RT capability (0xaa8) >>> [ 0.902485] cxl_core:cxl_probe_component_regs:102: pcieport 0000:0e:00.0: found BI Decoder capability (0xab4) >>> [ 1.221118] cxl_core:__cxl_bi_wait_commit:1032: pcieport 0000:0e:00.0: BI-ID commit wait took 250908us >>> [ 1.368581] cxl_core:__cxl_bi_wait_commit:1032: cxl_port port2: BI-ID commit wait took 146455us >>> [ 1.371579] cxl_core:__cxl_bi_ctrl_endpoint:1218: cxl_pci 0000:0f:00.0: BI requests enabled >>> >>> 6. Corrupted hw (commit timeout handling) >>> ----------------------------------------- >>> [ 1.003566] cxl_core:cxl_probe_component_regs:102: pcieport 0000:0e:00.0: found BI Decoder capability (0xab4) >>> [ 3.203147] pcieport 0000:0e:00.0: BI-ID commit timed out (2000000us) >>> [ 3.206048] cxl_port:cxl_endpoint_port_probe:190: cxl_port endpoint3: BI setup failed rc=-110 >>> >>> 7. Mixed Configurations (BI-capable Type 3 but DSP 68b) >>> ------------------------------------------------------- >>> [ 0.837902] cxl_mem:cxl_mem_probe:155: cxl_mem mem0: BI setup failed rc=-22 >>> >>> 8. Auto-discovered (committed) BI decoders >>> ------------------------------------------ >>> For testing, qemu hack emulates auto-committed decoder: >>> >>> [ 0.670374] cxl_core:devm_cxl_switch_port_decoders_setup:1282: cxl_port port1: Fallback to passthrough decoder >>> [ 0.718374] cxl_core:init_hdm_decoder:1128: cxl_port endpoint2: decoder2.0: range: 0x190000000-0x19fffffff iw: 1 ig: 256 >>> [ 0.728498] cxl_core:__cxl_bi_ctrl_endpoint:1200: cxl_pci 0000:0d:00.0: adopting firmware-enabled BI >>> [ 0.730880] cxl_core:devm_cxl_add_region:2829: cxl_acpi ACPI0017:00: decoder0.0: created HDM-DB region0 >>> [ 0.731906] cxl_core:__construct_region:3843: cxl_pci 0000:0d:00.0: mem0:decoder2.0: __construct_region region0 res: [mem 0x190000000-0x19fffffff flags 0x200] iw: 1 ig: 256 >>> [ 0.734473] cxl_core:cxl_region_sort_targets:2104: cxl region0: region sort successful >>> [ 0.739452] cxl_core:devm_cxl_add_dax_region:101: cxl_region region0: region0: register dax_region0 >>> [ 0.740239] cxl_core:cxl_bus_probe:2299: cxl_region region0: probe: 0 >>> # cat /sys/bus/cxl/devices/region0/commit >>> 1 >>> # cat /sys/bus/cxl/devices/decoder2.0/bi >>> 1 >>> >>> A committed BI decoder under a window without the BI restriction is >>> refused at region assembly: >>> >>> [ 0.794477] cxl_core:__cxl_bi_ctrl_endpoint:1200: cxl_pci 0000:0d:00.0: adopting firmware-enabled BI >>> [ 0.795396] cxl_pci 0000:0d:00.0: mem0:decoder2.0 BI decoder in a non-BI window >>> [ 0.796050] cxl_port:discover_region:55: cxl decoder2.0: failed to add to region: 0x190000000-0x19fffffff >>> >>> Applies against v7.2-rc5. Please consider for v7.3. >>> >>> [0] https://lore.kernel.org/linux-cxl/[email protected]/ >>> >>> Thanks! >>> >>> Davidlohr Bueso (9): >>> cxl: Add BI register probing and port initialization >>> cxl/pci: Add BI topology enable/disable >>> cxl/hdm: Add BI coherency support for endpoint decoders >>> cxl: Add HDM-DB region creation >>> cxl/hdm: Rename decoder coherency flags >>> cxl/region: Log the coherency model at region creation >>> cxl: Move BI setup to endpoint port probe >>> cxl/pci: Split BI capability probe from setup >>> cxl: Allow auto-committed BI hdm decoders >>> >>> Documentation/ABI/testing/sysfs-bus-cxl | 18 +- >>> drivers/cxl/acpi.c | 19 +- >>> drivers/cxl/core/core.h | 2 + >>> drivers/cxl/core/hdm.c | 68 ++++- >>> drivers/cxl/core/pci.c | 456 ++++++++++++++++++++++++++++++++ >>> drivers/cxl/core/port.c | 48 +++- >>> drivers/cxl/core/region.c | 97 ++++++- >>> drivers/cxl/core/regs.c | 14 + >>> drivers/cxl/cxl.h | 55 +++- >>> drivers/cxl/cxlmem.h | 2 + >>> drivers/cxl/port.c | 54 ++++ >>> include/cxl/cxl.h | 10 + >>> 12 files changed, 808 insertions(+), 35 deletions(-) >>> >>> -- >>> 2.39.5 >>