Re: [PATCH] cxl/Documentation: Spell out globbed sysfs attribute names
Alison Schofield <[email protected]> Tue, 4 Aug 2026 16:29:20 -0700
| Newsgroups | org.kernel.vger.linux-cxl |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 04, 2026 at 04:24:17PM -0700, Dave Jiang wrote:
>
>
> On 8/4/26 4:20 PM, Alison Schofield wrote:
> > Four entries in sysfs-bus-cxl use braced globs to document groups of
> > attributes. Where the glob factors out a common prefix, as in
> > cap_{pmem,ram,type2,type3}, no individual attribute name appears in
> > the file at all and none can be found by grep or get_abi.py search. In
> > every case the glob also keys get_abi.py validate on the glob string,
> > so duplicates against separately documented attributes go undetected.
> >
> > Replace the globs with consecutive What: lines for each attribute.
> > These lines continue to share the existing metadata and description
> > and follow the format used in sysfs-driver-ufs and sysfs-bus-iio.
> >
> > Also restore one missing blank line between entries.
> >
> > Verify with:
> > python3 tools/docs/get_abi.py -D Documentation/ABI/testing validate
> > python3 tools/docs/get_abi.py search cap_pmem
> > python3 tools/docs/get_abi.py search create_ram_region
> >
> > validate reports no sysfs-bus-cxl warning, and both searches now return
> > the stanza where they returned nothing before.
> >
> > Signed-off-by: Alison Schofield <[email protected]>
>
> Seems reasonable. One comment below.
>
> Reviewed-by: Dave Jiang <[email protected]>
>
You're faster than Sashiko ;)
snip
> > +
>
> Stray blank line?
It's mentioned in the commit log.
"Also restore one missing blank line between entries."
Pattern is 2 blank lines btw entries.
>
> > What: /sys/bus/cxl/devices/regionZ/extended_linear_cache_size
> > Date: October, 2025
> > KernelVersion: v6.19
> >
>