Re: [PATCH v2] cxl/pci: Fix NULL pointer dereference in reset detection
Guixin Liu <[email protected]>
| Newsgroups | org.kernel.vger.linux-cxl |
|---|---|
| Message-ID | <[email protected]> |
在 2026/8/12 15:38, Richard Cheng 写道: > Hi Guixin, > > I think we should cover the case for DVSEC-enulated decoder as well, where hdm is not NULL. > That could happen when HDM registers exist but are globally disabled, so the driver uses DVSEC ranges instead. > > In that case it will still pass your "if (!hdm)" check and reset detection still reads the unused HDM COMMITTED bit. > > Maybe we should also check for "!cxld->commit" ? > > Best regards, > Richard Cheng. Yes, and just "!cxld->commit" is ok, this cover "!hdm". Best Regards, Guixin Liu