Re: [PATCH V2] Documentation: Improve crash_kexec_post_notifiers description

On 02/09/2024 10:23, Simon Horman wrote:
> 
> Hi Guilherme,
> 
> Some subjective grammar nits.
> 
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index efc52ddc6864..351730108c58 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -913,12 +913,16 @@
>>  			the parameter has no effect.
>>  
>>  	crash_kexec_post_notifiers
>> -			Run kdump after running panic-notifiers and dumping
>> -			kmsg. This only for the users who doubt kdump always
>> -			succeeds in any situation.
>> -			Note that this also increases risks of kdump failure,
>> -			because some panic notifiers can make the crashed
>> -			kernel more unstable.
>> +			Only jump to kdump kernel after running the panic
>> +			notifiers and dumping kmsg. This option increases the
>> +			risks of a kdump failure, since some panic notifiers
>> +			can make the crashed kernel more unstable. In the
> 
> nit: In the configurations -> In configurations
> 
>> +			configurations where kdump may not be reliable,
>> +			running the panic notifiers can allow collecting more
>> +			data on dmesg, like stack traces from other CPUS or
>> +			extra data dumped by panic_print. Notice that some
> 
> nit: Notice that -> Note that
> 
>> +			code enables this option unconditionally, like
> 
> Maybe: some code enables -> some configurations enable
> 

Hey Simon, tnx for the suggestions, will change in the next version.
Cheers,


Guilherme