Re: kgdb replacing newline with CRLF in custom query response

On Fri, Nov 15, 2024 at 02:49:33PM +0000, Daniel Thompson wrote:
> On Fri, Nov 08, 2024 at 09:37:32AM -0800, Doug Anderson wrote:

[snip]

> > Bleh. It _probably_ wouldn't be a big deal to do the LF -> CRLF for
> > all these, but I don't know for sure. I guess worst case you could add
> > some flag in the "dbg_io_ops" and figure out how to set it just for
> > UARTs?
> 
> I find myself in a similar position to Doug.
> 
> It sounds reasonable to move the CR synthesis into kdb_msg_write() but I
> also am not certain the other polling backends will handle this correctly.
> 
> However I did apply the following patch and run a few tests and it all
> looks good. Specifically there are no regressions from the kgdb test
> suite although that's unsurprising since that suite exclusively tests
> the serial port. I also fired up the kdb,kms polling backends on x86
> and verified that I didn't get double line feeds in kdb (I did not).
> 
> That means I'd certainly accept patches based on Doug's idea and if it
> proves later that we have to revert and add a new dbg_io_ops pointer to
> switch the handler between binary and ascii modes then so be it!

Perfect, thanks for testing this, Daniel. Amal will include a
preparatory patch along those lines when he sends the VMCOREINFO packet
patch.

Thanks,
Omar