Re: [PATCH 09/28] arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix: Swapped QMP PHY `vdda-phy` and `vdda-pll` supplies are also present on many other SoC platforms.
--

--- Patch [9]: [PATCH 09/28] arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit b676d59f3c957659ff365b6c3e896016ef8c4405
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

This commit swaps back the vdda-phy and vdda-pll supplies for the sm8450
USB QMP PHYs. The supplies were previously swapped, feeding 1.2V to a 0.88V
line and 0.91V to a 1.2V line.

> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index b37998cd9a2c3..4ade28f40cae0 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -1214,8 +1214,8 @@ &usb_1_hsphy {
>  &usb_1_qmpphy {
>  	status = "okay";
>  
> -	vdda-phy-supply = <&vreg_l6b_1p2>;
> -	vdda-pll-supply = <&vreg_l1b_0p91>;
> +	vdda-phy-supply = <&vreg_l1b_0p91>;
> +	vdda-pll-supply = <&vreg_l6b_1p2>;

[Severity: High]
This is a pre-existing issue, but does this same swapped regulator bug exist 
in other board files that should also be addressed?

For instance, looking at arch/arm64/boot/dts/qcom/sc7280-idp.dtsi in &usb_1_qmpphy:

	vdda-phy-supply = <&vreg_l6b_1p2>;
	vdda-pll-supply = <&vreg_l1b_0p8>;

And similarly in arch/arm64/boot/dts/qcom/qcm6490-idp.dts in &usb_1_qmpphy:

	vdda-phy-supply = <&vreg_l6b_1p2>;
	vdda-pll-supply = <&vreg_l1b_0p912>;

Should these other boards also be included in this fix to prevent overvolting
the PHYs on those platforms?

>  };
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9