Re: [PATCH 08/28] arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] Incomplete fix for swapped USB QMP PHY vdda-phy/vdda-pll supplies across the QCOM devicetrees. The same reversed regulator configuration remains unfixed in several other SoCs, notably SM8450, SM8550, and SM8650.
--

--- Patch [8]: [PATCH 08/28] arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 2073beeb341c58218ee83d7e126de860cc972a2f
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

The commit fixes a hardware configuration issue where the vdda-phy and
vdda-pll power supplies for the USB QMP PHY were swapped in SM8350
device trees. It corrects the assignments for the HDK, Surface Duo 2,
MTP, and Sagami boards so they receive the expected ~0.88V and 1.2V
respectively.

> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index 5f975d0094658..b43dbb5921b18 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -860,8 +860,8 @@ &usb_1_hsphy {
>  &usb_1_qmpphy {
>  	status = "okay";
>  
> -	vdda-phy-supply = <&vreg_l6b_1p2>;
> -	vdda-pll-supply = <&vreg_l1b_0p88>;
> +	vdda-phy-supply = <&vreg_l1b_0p88>;
> +	vdda-pll-supply = <&vreg_l6b_1p2>;
>  };

[Severity: Medium]
This is a pre-existing issue, but it looks like the swapped regulator
assignments remain unfixed in several other device trees.

For example, in sm8450-hdk.dts, usb_1_qmpphy still has a 1.2V supply assigned
to vdda-phy-supply and a 0.91V supply to vdda-pll-supply:

arch/arm64/boot/dts/qcom/sm8450-hdk.dts:usb_1_qmpphy {
	status = "okay";

	vdda-phy-supply = <&vreg_l6b_1p2>;
	vdda-pll-supply = <&vreg_l1b_0p91>;
};

The same uncorrected pattern appears in sm8550-hdk.dts and sm8650-hdk.dts 
for usb_dp_qmpphy, as well as in sm8450-sony-xperia-nagara.dtsi.

Should these other device trees be updated in a follow-up patch to ensure 
their PHYs receive the correct voltages?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8