Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but the patch provides an incomplete fix by only adding the missing `power-domains` property to `sdmmc1` in `stm32mp231.dtsi`, leaving the identical omission unfixed in the sibling SoC file `stm32mp251.dtsi`.
--
--- Patch [2]: [RESEND PATCH v7 02/16] arm64: dts: st: add power-domains to sdmmc1 on stm32mp231 ---
commit 5347308e7a8cc88eceb04108886bd5138aa92189
Author: Dario Binacchi <[email protected]>
arm64: dts: st: add power-domains to sdmmc1 on stm32mp231
This commit adds the missing power-domains property to the sdmmc1 node in
the stm32mp231 device tree. This aligns it with other peripheral nodes and
ensures proper power domain mapping.
> diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> index 9e1d240888ff2..0feb8943efae6 100644
> --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> @@ -727,6 +727,7 @@ sdmmc1: mmc@48220000 {
> cap-mmc-highspeed;
> max-frequency = <120000000>;
> access-controllers = <&rifsc 76>;
> + power-domains = <&cluster_pd>;
[Severity: High]
This isn't a bug introduced by this patch, but does the sdmmc1 node in
stm32mp251.dtsi also need this property updated?
Looking at arch/arm64/boot/dts/st/stm32mp251.dtsi, the sdmmc1 node appears to
be missing the same property:
arch/arm64/boot/dts/st/stm32mp251.dtsi:sdmmc1:
sdmmc1: mmc@48220000 {
compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell";
...
Without the power-domains property, the generic power domain framework is
unaware that sdmmc1 depends on cluster_pd. If no other active peripherals
hold a reference to cluster_pd, the framework could power it down, abruptly
cutting power to the sdmmc1 controller.
This would cause I/O errors or kernel panics on STM32MP25 boards utilizing
sdmmc1 when peripheral power domains are dynamically managed.
Could this identical omission be fixed in the sibling SoC file as well?
> status = "disabled";
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.