Re: [PATCH v3 2/2] iio: dac: dac8163: Add driver for DAC8163

August 2, 2026 at 11:19 PM, "David Lechner" <[email protected]> wrote:


> 
> On 8/2/26 11:07 AM, Lukas Metz wrote:
...
> >  +#define LDAC_CHANNEL_A_MASK BIT(0)
> >  +#define LDAC_CHANNEL_B_MASK BIT(1)
> >  +#define VREF_MASK BIT(0)
> >  +
> >  +#define DAC8163_INTERNAL_REF_mV 2500
> >  +#define DAC8163_RES_12_BIT 12
> >  +#define DAC8163_RES_14_BIT 14
> >  +#define DAC8163_RES_16_BIT 16
> > 
> Macros that just map to a number that is part of the macro name
> aren't that helpful. We can just use the number directly.
> 
Each of them repeats 4 times. I think typing a number that many times 
is more error prone than having a macro.
> > 
> >
>

--
Best regards,
Sirat