Re: [PATCH 2/2] dpll: zl3073x: add ZL30643 chip support
Ivan Vecera <[email protected]> Mon, 3 Aug 2026 13:51:24 +0200
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 7/30/26 7:08 PM, Vincent Jardin wrote: > Hi Ivan, > >> Hi Vincent, >> I'm not sure that all driver's functionality is supported by ZL3064x. Did you test everything? >> >> I need to check datasheets for this chip models, maybe some device flags will be needed. > > I checked both datasheets. They are the same registers: > > - the register descriptions are verbatim identical > > - same chip-ID encoding (base / A +0x1000 / B +0x2000 / 7x7 +0x8000) > > So ZL_CHIP_INFO(0x0E3B, 3, ZL3073X_FLAG_REF_PHASE_COMP_32) is correct > and no new device flag is needed: the ref-phase mechanism the flag > governs is identical between the families. > > The only differences seem to be non-register related: line card vs > central system and the min input-frequency spec (1 kHz vs 0.5 Hz). Hi Vincent, Yes, minimal reference frequency for zl3064x is 1000Hz and also supported bandwidth range is different (not relevant now). So, we need to - add new field into zl3073x_chip_info that will describe minimal input reference frequency - add a check into zl3073x_pin_check_freq() Let me know if you want to do it yourself or if I should do it (I would send it along with your two patches). Thanks, Ivan