Re: [PATCH v3 1/6] dt-bindings: spmi: apple,spmi: Add t603x

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] New provider capabilities (`interrupt-controller` and `#interrupt-cells`) are added without proper requirements or dependencies, and the example is not updated, violating subsystem guidelines.
--

--- Patch [1]: [PATCH v3 1/6] dt-bindings: spmi: apple,spmi: Add t603x ---
commit 93ff9762b75f8c79f11e2bf64785642aca6a9d56
Author: Sasha Finkelstein <[email protected]>

dt-bindings: spmi: apple,spmi: Add t603x

Add t603x compatibles, interrupt support, and support for SPMI
controllers that are not always-on. The interrupt-controller property
is kept optional since it is only needed on a subset of the controllers.

> diff --git a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> index 3e5b14bc8c317..fceed47b2cd17 100644
> --- a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> +++ b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml

[ ... ]

> @@ -34,6 +37,18 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +    description: Optional, operates in polled mode if not present
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2

[Severity: Medium]
Are these new provider capabilities properly enforced?

The guidelines state that when hardware gains new provider capabilities, the
binding must add the corresponding standard properties to the required list.

Since "interrupt-controller" is optional here, incomplete device tree nodes
could silently pass schema validation if they declare "interrupt-controller"
but omit "#interrupt-cells".

Should there be a dependencies block added to ensure "#interrupt-cells" is
present whenever the "interrupt-controller" property is used?

For example:
dependencies:
  interrupt-controller: [ "#interrupt-cells" ]

Also, should the examples section be updated to demonstrate these newly added
provider capabilities?

> +
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1