Re: [PATCH 1/1] arm64: dts: ti: k3-am69-aquila: Add Toradex DSI to LVDS adapter with the 10.1" V2 display

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string 'ilitek,ili251x' is not documented in any device tree binding schema.
--

--- Patch [1]: [PATCH 1/1] arm64: dts: ti: k3-am69-aquila: Add Toradex DSI to LVDS adapter with the 10.1" V2 display ---
commit 73e2dedf7bdfd04739a496a9f0ff1282f074c0ec
Author: Leonardo Costa <[email protected]>

arm64: dts: ti: k3-am69-aquila: Add Toradex DSI to LVDS adapter with the 10.1" V2 display

Add a device tree overlay for the Toradex DSI to LVDS Adapter with the
Toradex Capacitive Touch Display 10.1" LVDS V2. The adapter connects to the
Aquila DSI_1 interface. It is based on the Texas Instruments SN65DSI84
DSI-to-LVDS bridge and drives an Opto Logic SCX1001511GGC49 panel with an
ILITEK ILI251x capacitive touch controller.

Link: https://developer.toradex.com/hardware/accessories/add-ons/dsi-lvds-adapter
Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-101inch-lvds

[ ... ]

> diff --git a/arch/arm64/boot/dts/ti/k3-am69-aquila-dsi-to-lvds-v2-panel-cap-touch-10inch.dtso b/arch/arm64/boot/dts/ti/k3-am69-aquila-dsi-to-lvds-v2-panel-cap-touch-10inch.dtso
> new file mode 100644
> index 0000000000000..834f23e75cbc3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am69-aquila-dsi-to-lvds-v2-panel-cap-touch-10inch.dtso

[ ... ]

> +&i2c_dsi_0 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;

[ ... ]

> +	touchscreen@41 {
> +		compatible = "ilitek,ili251x";

[Severity: Low]
Is this compatible string documented in a device tree binding schema? 

It appears that "ilitek,ili251x" is missing from the binding documentation,
which causes dtbs_check warnings during the build.

> +		reg = <0x41>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_17_dsi_1>, <&pinctrl_gpio_18_dsi_1>;
> +		/* Aquila GPIO_17_DSI_1 (AQUILA B42) */
> +		interrupt-parent = <&main_gpio0>;
> +		interrupts = <12 IRQ_TYPE_EDGE_RISING>;
> +		/* Aquila GPIO_18_DSI_1 (AQUILA B43) */
> +		reset-gpios = <&main_gpio0 31 GPIO_ACTIVE_LOW>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1