Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sm8550-pas: Make SDX75, Hawi and Maili MPSS fallback to SM8650

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:
- [Medium] Removing `qcom,sdx75-mpss-pas` from the standalone enum and enfo=
rcing a fallback breaks schema validation for existing DTBs and the in-tree=
 DTS.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: remoteproc: qcom,sm8550-pas: Make S=
DX75, Hawi and Maili MPSS fallback to SM8650 ---
commit 47a9ace0c12a078f309c8a844f59ffd712d4d63a
Author: Mukesh Ojha <[email protected]>

dt-bindings: remoteproc: qcom,sm8550-pas: Make SDX75, Hawi and Maili MPSS f=
allback to SM8650

SDX75, Hawi and Maili MPSS are compatible with the SM8650 MPSS as
they share the same set of interrupts, memory regions and power domains.
Rather than describing them as standalone compatibles, model them as
fallbacks to qcom,sm8650-mpss-pas.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas=
.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -18,9 +18,6 @@ properties:
>      oneOf:
>        - enum:
>            - qcom,eliza-cdsp-pas
> -          - qcom,hawi-mpss-pas
> -          - qcom,maili-mpss-pas
> -          - qcom,sdx75-mpss-pas
>            - qcom,sm8550-adsp-pas

[ ... ]

> @@ -49,6 +46,12 @@ properties:
>        - items:
>            - const: qcom,sm8750-cdsp-pas
>            - const: qcom,sm8650-cdsp-pas
> +      - items:
> +          - enum:
> +              - qcom,hawi-mpss-pas
> +              - qcom,maili-mpss-pas
> +              - qcom,sdx75-mpss-pas
> +          - const: qcom,sm8650-mpss-pas

[Severity: Medium]
Does removing the standalone compatible strings and enforcing them only as=
=20
part of a 2-item array break backward compatibility for existing device tre=
es?

If older device trees, such as arch/arm64/boot/dts/qcom/sdx75.dtsi, use=20
qcom,sdx75-mpss-pas without the newly required fallback, will they start=20
failing dtbs_check validation?

> =20
>    reg:
>      maxItems: 1

[ ... ]

> @@ -205,11 +208,9 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          enum:
> -            - qcom,hawi-mpss-pas
> -            - qcom,maili-mpss-pas
> -            - qcom,sdx75-mpss-pas
> -            - qcom,sm8650-mpss-pas
> +          contains:
> +            enum:
> +              - qcom,sm8650-mpss-pas
>      then:
>        properties:
>          interrupts:

[Severity: Medium]
Since older device trees might not include the fallback string, does
removing the standalone compatible strings from these allOf conditional=20
blocks mean those device trees will silently bypass validation for=20
interrupts, power-domains, and memory-regions constraints?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260803180021.2036=
[email protected]?part=3D1